Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): return correct cors headers for ingestion endpoint #3976

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

schoren
Copy link
Contributor

@schoren schoren commented Aug 16, 2024

This PR fixes the agent's OTLP server http ingestion server so that it provides the correct CORS headers. This allows sending traces from a web client directly to the agent.

Changes

  • add cors middleware to the endpoint

Fixes

  • fix incorrect default domain using http instead of https

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Screenshots

Screenshot 2024-08-16 at 17 50 49

Screenshot 2024-08-16 at 17 50 35

Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracetest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 8:52pm

@schoren schoren merged commit 7a16cd8 into main Aug 19, 2024
38 checks passed
@schoren schoren deleted the fix-agent-ingestion-cors branch August 19, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants