fix: oauth path building #3991
Merged
fix: oauth path building #3991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xoscar
approved these changes
Aug 28, 2024
schoren
reviewed
Aug 28, 2024
cli/pkg/oauth/oauth.go
Outdated
| @@ -58,7 +59,7 @@ func (s *OAuthServer) GetAuthJWT() error { | |||
| return fmt.Errorf("failed to start oauth server: %w", err) | |||
| } | |||
|
|
|||
| loginUrl := fmt.Sprintf("%soauth?callback=%s", s.frontendEndpoint, url) | |||
| loginUrl := path.Join(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url)) | |||
There was a problem hiding this comment.
Suggested change
| loginUrl := path.Join(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url)) | |
| loginUrl := url.JoinPath(s.frontendEndpoint, fmt.Sprintf("oauth?callback=%s", url)) |
There was a problem hiding this comment.
I had to create an alias for url as there is already an url var in this scope.
neturl net/url
schoren
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes how we build oauth endpoint paths by replacing
fmt.Sprintfwithpath.JoinChecklist