add support for feishu #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Signed-off-by: wanjunlei <[email protected]>
benjaminhuo
requested changes
Mar 18, 2022
pkg/apis/v2beta2/receiver_types.go
Outdated
| @@ -244,6 +244,41 @@ type PushoverReceiver struct { | |||
| TmplText *ConfigmapKeySelector `json:"tmplText,omitempty"` | |||
| } | |||
|
|
|||
| // FeishuChatBot is the configuration of ChatBot | |||
| type FeishuChatBot struct { | |||
| // The webhook of ChatBot which the message will send to. | |||
There was a problem hiding this comment.
// The webhook of ChatBot which the message will send to.
=>
// The webhook of the ChatBot to which the message will be sent.
pkg/apis/v2beta2/receiver_types.go
Outdated
| // Custom keywords of ChatBot | ||
| Keywords []string `json:"keywords,omitempty"` | ||
|
|
||
| // Secret of ChatBot, you can get it after enabled signature verification of ChatBot. |
There was a problem hiding this comment.
=>
// Secret of ChatBot, you can get it after enabling signature verification of ChatBot.
pkg/apis/v2beta2/receiver_webhook.go
Outdated
| "must specify one of: `user`, `department` or `chatbot`")) | ||
| } | ||
|
|
||
| if err := validateSelector(r.Spec.Wechat.AlertSelector); err != nil { |
There was a problem hiding this comment.
Shouldn't be Wechat.AlertSelector for feishu
pkg/constants/constants.go
Outdated
| @@ -4,11 +4,13 @@ const ( | |||
| HTML = "html" | |||
| Text = "text" | |||
| Markdown = "markdown" | |||
| Post = "post" | |||
There was a problem hiding this comment.
I think we can add a comment here to explain what is post format, maybe with the link below
https://open.feishu.cn/document/uAjLw4CM/ukTMukTMukTM/im-v1/message/create_json#45e0953e
Signed-off-by: wanjunlei <[email protected]>
benjaminhuo
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wanjunlei [email protected]
#120