add webhook and dingtalk support #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuo
approved these changes
Oct 22, 2020
| @@ -64,7 +64,6 @@ spec: | |||
| - wechatApiAgentId | |||
| - wechatApiCorpId | |||
| - wechatApiSecret | |||
| - wechatApiUrl | |||
There was a problem hiding this comment.
wechatApiUrl is not used anymore?
|
That's lots of good changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code of receivers managed, simplified the development for the new receiver
Add webhook and dingtalk support
Now it supports to mount volumes to the notification manager
Now it supports to customize the message template
Redefine the default message template, now the message format is like this
Delay reading encrypted data from secret, so that the change of the secret can take effect without notification manager restarting