Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parallel sending to optimize performance #40

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Use parallel sending to optimize performance #40

merged 2 commits into from
Nov 4, 2020

Conversation

wanjunlei
Copy link
Collaborator

  1. Use parallel sending to optimize performance
  2. Aggregate the message send to wechat and dingtalk, reduce the API calls.
  3. Add args to notification manager, to support change the log level

@wanjunlei wanjunlei requested a review from benjaminhuo November 3, 2020 03:54
benjaminhuo
benjaminhuo requested changes Nov 3, 2020
View reviewed changes
pkg/apis/v1alpha1/notificationmanager_types.go Outdated Show resolved Hide resolved
pkg/notify/notifier/dingtalk/dingtalk.go Outdated Show resolved Hide resolved
pkg/async/group.go Show resolved Hide resolved
@benjaminhuo benjaminhuo merged commit fc84ee1 into kubesphere:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminhuo benjaminhuo benjaminhuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanjunlei @benjaminhuo