Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adapter sink #51

Merged
merged 3 commits into from
Dec 3, 2020
Merged

add adapter sink #51

merged 3 commits into from
Dec 3, 2020

Conversation

wanjunlei
Copy link
Collaborator

No description provided.

Signed-off-by: wanjunlei <[email protected]>
Signed-off-by: wanjunlei <[email protected]>
@wanjunlei wanjunlei requested a review from benjaminhuo December 2, 2020 09:12
Copy link
Member

@benjaminhuo benjaminhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.
Just some minor changes needed

adapter/sink/Dockerfile Show resolved Hide resolved
@@ -0,0 +1,3 @@
# notification-adapter

Notification-adapter receive notifications from notifcation manager and export with the socket.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=> and then send it to a TCP endpoint.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add more instructions here on how to use it together with the Notification Manager?

Signed-off-by: wanjunlei <[email protected]>
@benjaminhuo benjaminhuo merged commit bd11c0f into kubesphere:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants