fix SMS provider huawei: support more placeholders #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhu733756 <[email protected]>
zhu733756
force-pushed
the
support-for-huaweicloud-sms
branch
from
c747966 to
5392fde
Compare
benjaminhuo
reviewed
Aug 2, 2021
README.md
Outdated
| For a detailed description, if you have a template like this: | ||
| ``` | ||
| [KubeSphere alerts] alertname = ${TEXT}, alerttype = ${TEXT}, severity = ${TEXT}, message = ${TEXT}, summary = ${TEXT} | ||
| [KubeSphere alerts] alertname = ${TEXT}, alerttype = ${TEXT}, node = ${TEXT}, namespace = ${TEXT}, pod = ${TEXT}, cluster = ${TEXT}, workload = ${TEXT}, severity = ${TEXT}, message = ${TEXT}, summary = ${TEXT} |
There was a problem hiding this comment.
The order could be adjusted like below to put the most important messages to the front and rearrange the labels in a more logical way:
alertname = ${TEXT}, severity = ${TEXT}, message = ${TEXT}, summary = ${TEXT}, alerttype = ${TEXT}, cluster = ${TEXT}, node = ${TEXT}, namespace = ${TEXT}, workload = ${TEXT}, pod = ${TEXT}
Signed-off-by: zhu733756 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhu733756 [email protected]
/cc @wanjunlei @benjaminhuo