Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-model JSON imports #290

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Ignore non-model JSON imports #290

merged 4 commits into from
Jun 9, 2023

Conversation

kubukoz
Copy link
Owner

@kubukoz kubukoz commented Jun 9, 2023

Closes #289

Before this change, all files in imports would've been passed to the model loader. After this change, only the following files will be used:

  • .smithy files
  • files that are valid JSON that contains {"smithy": "any string"}.

Copy link
Owner Author

@kubukoz kubukoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@kubukoz kubukoz merged commit a954643 into main Jun 9, 2023
@kubukoz kubukoz deleted the ignore-non-model-jsons branch June 9, 2023 19:11
kubukoz added a commit that referenced this pull request Sep 24, 2023
This is no longer necessary - Smithy filters these out automatically
now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore non-smithy JSON files for model loading
1 participant