-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: config:init should create ESM version of jest.config.js when type = module #4012
Comments
PR is welcome :) |
It would have been nice to show how, for those of us who have this bug and are looking to fix it. |
You can either change the config's extension to or change module.exports = {
// config
} to ESM (any requires should also be changed to export default {
// same config
} |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://github.com/kulshekhar/ts-jest)) | dependencies | patch | [`29.1.3` -> `29.1.4`](https://renovatebot.com/diffs/npm/ts-jest/29.1.3/29.1.4) | --- ### Release Notes <details> <summary>kulshekhar/ts-jest (ts-jest)</summary> ### [`v29.1.4`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2914-2024-05-28) [Compare Source](kulshekhar/ts-jest@v29.1.3...v29.1.4) ##### Bug Fixes - fix(transformer): allow transforming of .cts/.mts extensions. ([#​3996](kulshekhar/ts-jest#3996)) ([b8f6eaa](kulshekhar/ts-jest@b8f6eaa)), closes [#​3996](kulshekhar/ts-jest#3996) ##### Features - feat: make cli generate esm config based on `type: "module"` ([#​4210](kulshekhar/ts-jest#4210)) ([81a5f64](kulshekhar/ts-jest@81a5f64)), closes [#​4210](kulshekhar/ts-jest#4210) [#​4012](kulshekhar/ts-jest#4012) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/255 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://github.com/kulshekhar/ts-jest)) | dependencies | patch | [`29.1.2` -> `29.1.5`](https://renovatebot.com/diffs/npm/ts-jest/29.1.2/29.1.5) | --- ### Release Notes <details> <summary>kulshekhar/ts-jest (ts-jest)</summary> ### [`v29.1.5`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2915-2024-06-16) [Compare Source](kulshekhar/ts-jest@v29.1.4...v29.1.5) ##### Bug Fixes - build(deps-dev): bump braces ([5560334](kulshekhar/ts-jest@5560334)), ([59026b4](kulshekhar/ts-jest@59026b4)), ([0d9e359](kulshekhar/ts-jest@0d9e359)) ### [`v29.1.4`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2914-2024-05-28) [Compare Source](kulshekhar/ts-jest@v29.1.3...v29.1.4) ##### Bug Fixes - fix(transformer): allow transforming of .cts/.mts extensions. ([b8f6eaa](kulshekhar/ts-jest@b8f6eaa)), closes [#​3996](kulshekhar/ts-jest#3996) ##### Features - feat: make cli generate esm config based on `type: "module"` ([81a5f64](kulshekhar/ts-jest@81a5f64)), closes [#​4210](kulshekhar/ts-jest#4210) [#​4012](kulshekhar/ts-jest#4012) ### [`v29.1.3`](https://github.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2913-2024-05-21) [Compare Source](kulshekhar/ts-jest@v29.1.2...v29.1.3) ##### Bug Fixes - add `@jest/transform` as an optional peer dependency ([0ba7f86](kulshekhar/ts-jest@0ba7f86)) - bring back Node 14 support ([eda56a7](kulshekhar/ts-jest@eda56a7)) ##### Performance Improvements - remove ts resolved module cache file ([4c88da5](kulshekhar/ts-jest@4c88da5)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://git.vylpes.xyz/RabbitLabs/vylbot-app/pulls/438 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Version
29.0.5
Steps to reproduce
"type": "module"
in itspackage.json
jest
,typescript
, andts-jest
config:init
script to generatejest.config.js
jest
Expected behavior
Jest reads the config file and runs normally if tests found.
Actual behavior
Jest can't read the config file because:
ReferenceError: module is not defined in ES module scope
Debug log
n/a
Additional context
It's not the biggest bug, and can easily be fixed manually, by changing the generated
jest.config.js
to ESM. But it would be nice if it just worked out of the box.It should be a simple fix in the
cli/config/init.ts
script, I can make a PR if it's okay.Environment
The text was updated successfully, but these errors were encountered: