Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): add ServiceMonitor for controlplane metrics scraping #12843

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

synthe102
Copy link

@synthe102 synthe102 commented Feb 13, 2025

Motivation

This change allows to create a ServiceMonitor resource instance used by prometheus operator and various telemetry collectors to scrape control plane metrics. While the prometheus.io/scrape Service annotation is used by some collectors, it seems that ServiceMonitors adoption is better.

Implementation information

Adds a new boolean controlPlane.serviceMonitor.enabled which default to false, controlling the templating of the ServiceMonitor.

Supporting documentation

Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@synthe102 synthe102 force-pushed the master branch 4 times, most recently from 5f1cf65 to c9e304f Compare February 13, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants