Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable import module for docker compose packages #2282

Closed
wants to merge 4 commits into from

Conversation

tedim52
Copy link
Contributor

@tedim52 tedim52 commented Mar 13, 2024

Description

REMINDER: Tag Reviewers, so they get notified to review

Is this change user facing?

YES/NO

References (if applicable)

@tedim52 tedim52 force-pushed the tedi/import-module-compose branch from c4de699 to df54e99 Compare March 13, 2024 21:22
@kurtosis-tech kurtosis-tech deleted a comment from gitguardian bot Mar 13, 2024
@tedim52 tedim52 force-pushed the tedi/import-module-compose branch from df54e99 to 42e18b2 Compare March 13, 2024 21:24
Copy link

gitguardian bot commented Mar 13, 2024

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9583343 Triggered Generic Password dd58852 core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go View secret
9966505 Triggered Generic Password dd58852 core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go View secret
9966505 Triggered Generic Password dd58852 core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go View secret
9966505 Triggered Generic Password dd58852 core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go View secret
9966505 Triggered Generic Password dd58852 core/server/api_container/server/startosis_engine/startosis_interpreter_plan_yaml_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@tedim52 tedim52 marked this pull request as draft March 13, 2024 21:36
@tedim52
Copy link
Contributor Author

tedim52 commented Mar 25, 2024

implemented in #2327

@tedim52 tedim52 closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant