Fix URL parsing w/ trailing slash & querystring #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2-dev #1539 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 98 98
Lines 6749 6749
=======================================
Hits 6312 6312
Misses 437 437
Continue to review full report at Codecov.
|
Aschen
approved these changes
Dec 4, 2019
alexandrebouthinon
approved these changes
Dec 6, 2019
Merged
scottinet
added a commit
that referenced
this pull request
Dec 6, 2019
# [2.0.1](https://github.com/kuzzleio/kuzzle/releases/tag/2.0.1) (2019-12-06) #### Bug fixes - [ [#1534](#1534) ] Configured server limit were not applied to some m* and deleteByQuery routes ([scottinet](https://github.com/scottinet)) - [ [#1539](#1539) ] Fix URL parsing w/ trailing slash & querystring ([scottinet](https://github.com/scottinet)) - [ [#1531](#1531) ] Enforce naming rules on indexes and collections ([scottinet](https://github.com/scottinet)) - [ [#1530](#1530) ] Rejects new API requests during a shutdown sequence ([scottinet](https://github.com/scottinet)) - [ [#1504](#1504) ] Do not delete a profile still assigned to users ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#1533](#1533) ] Add plugin version to server info ([Aschen](https://github.com/Aschen)) - [ [#1536](#1536) ] Prevent overloads caused by pre-funnel pipes ([scottinet](https://github.com/scottinet)) - [ [#1543](#1543) ] Use [email protected] ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where an URL containing both a trailing slash and a querystring would be incorrectly parsed.
How to reproduce
The following HTTP GET request works fine:
http://localhost:7512/_now?prettyBut not this one without this PR:
http://localhost:7512/_now/?prettyBoth requests are equivalent and should be regarded as identical.
Other changes
Use the WHATWG URL parsing API instead of the legacy (and deprecated) Node.js URL parser.Unfortunately, the latter was much more adapted to URL parsing server-side than the former. 😑
Reverted to the legacy URL API because of: