feat(go_indexer): support flag field vars

kythe · Mar 18, 2024 · df747be · df747be
1 parent c067658
commit df747be
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/kythe/go/indexer/emit.go b/kythe/go/indexer/emit.go
@@ -1087,6 +1087,8 @@ func (e *emitter) flagNameNode(caller *funcInfo, flagName string) *spb.VName {
 func findIdentifier(expr ast.Expr) *ast.Ident {
 	for expr != nil {
 		switch e := expr.(type) {
+		case *ast.SelectorExpr:
+			return e.Sel
 		case *ast.UnaryExpr:
 			if e.Op != token.AND {
 				return nil

diff --git a/kythe/go/indexer/testdata/flags.go b/kythe/go/indexer/testdata/flags.go
@@ -35,6 +35,8 @@ var (
 	featureFlag = flag.Int("feature", 42, "DEPRECATED: don't use this")
 )
 
+type Options struct{ Option int }
+
 func init() {
 	//- @localFlag defines/binding LocalFlag
 	//- LocalFlag.node/kind variable
@@ -60,6 +62,13 @@ func init() {
 	//- FuncFlagDoc.text "Func flag"
 	flag.BoolFunc("func_flag", "Func flag", func(s string) error { return nil })
 
+	opts := Options{}
+
+	//- @"\"field_flag\"" defines/binding FieldFlag
+	//- @Option ref OptField
+	//- OptField denotes FieldFlag
+	flag.IntVar(&opts.Option, "field_flag", 0, "Field flag")
+
 	fmt.Println(*flagVar, *localFlag) // use flag vars
 }