feat(ui): improve the new highlighting system #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigmanificient
force-pushed
the
proof-of-concept
branch
3 times, most recently
from
269e8d3 to
82b9f6c
Compare
Sigmanificient
force-pushed
the
proof-of-concept
branch
from
82b9f6c to
022ffa3
Compare
kyu08
reviewed
Jan 5, 2025
There was a problem hiding this comment.
@Sigmanificient
Great work! This is awesome.
I'll add some commit to this PR to follow up tiny things.
TODO(@kyu08):
- add theme's and rust-embed's license to
CREDITS - extract process that determine extension as
RunnerType's method
kyu08
changed the title
kyu08
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
@Sigmanificient
Your investigation and implementation were fantastic!
Without your effort, #416 could not have been resolved. 🎉
Thank you so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #416
This is a rough implementation, so the tmTheme is imported in the root. I don't have enough rust capabilities to offload it with submodules like bat.