Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): map ctrl + n/p to move cursor up/down #432

Merged
merged 5 commits into from
Jan 25, 2025
Merged

feat(ui): map ctrl + n/p to move cursor up/down #432

merged 5 commits into from
Jan 25, 2025

Conversation

ShoheiKamiya
Copy link
Contributor

@ShoheiKamiya ShoheiKamiya commented Jan 25, 2025 •
edited
Loading

Fixes: #393

@ShoheiKamiya ShoheiKamiya marked this pull request as ready for review January 25, 2025 02:34
@ShoheiKamiya ShoheiKamiya marked this pull request as draft January 25, 2025 07:34
@ShoheiKamiya ShoheiKamiya marked this pull request as ready for review January 25, 2025 08:39
kyu08
kyu08 requested changes Jan 25, 2025
View reviewed changes
Copy link
Owner

@kyu08 kyu08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing! It looks awesome! 👍

Adding to this, I want you to add this handling to the case CurrentPnae::History is selected.

@ShoheiKamiya
Copy link
Contributor Author

@kyu08
Got it! I missed that. I'll implement it.

@ShoheiKamiya ShoheiKamiya force-pushed the fix-393 branch 2 times, most recently from 0365bb1 to c2b375c Compare January 25, 2025 09:22
@ShoheiKamiya ShoheiKamiya requested a review from kyu08 January 25, 2025 09:27
@ShoheiKamiya
Copy link
Contributor Author

@kyu08
I've implemented it. Could you review it again? Thanks!

kyu08
kyu08 reviewed Jan 25, 2025
View reviewed changes
src/usecase/tui/app.rs Outdated Show resolved Hide resolved
@ShoheiKamiya ShoheiKamiya requested a review from kyu08 January 25, 2025 10:04
kyu08
kyu08 approved these changes Jan 25, 2025
View reviewed changes
Copy link
Owner

@kyu08 kyu08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Thanks for taking time to this improvement!
Your contribution have made fzf-make even more useful! 🚀

@kyu08 kyu08 merged commit fb1b0f5 into kyu08:main Jan 25, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyu08 kyu08 kyu08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(ui): map ctrl + n/p to move cursor up/down
2 participants
@ShoheiKamiya @kyu08