Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BA-519): Update SDK to retrieve and use IDs for VFolder API operations instead of names #3471

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(BA-519): Update SDK to retrieve and use IDs for VFolder API operations instead of names #3471

merged 1 commit into from
Jan 17, 2025
+116 −40

Conversation

HyeockJinKim
Copy link
Collaborator

@HyeockJinKim HyeockJinKim commented Jan 16, 2025 •
edited by fregataa
Loading

resolves #3466 (BA-519)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@HyeockJinKim HyeockJinKim self-assigned this Jan 16, 2025
@github-actions github-actions bot added comp:client Related to Client component size:L 100~500 LoC labels Jan 16, 2025
@HyeockJinKim HyeockJinKim changed the title feat(BA-519): Raise exception if multiple VFolders exist in decorator feat(BA-519): Update SDK to retrieve and use IDs for VFolder API operations instead of names Jan 16, 2025
@HyeockJinKim HyeockJinKim added this to the 24.03 milestone Jan 16, 2025
fregataa
fregataa approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@fregataa fregataa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@HyeockJinKim HyeockJinKim force-pushed the fix/vfolder-decorator branch 3 times, most recently from a472541 to f281d42 Compare January 17, 2025 06:17
Base automatically changed from fix/vfolder-decorator to main January 17, 2025 06:25
@HyeockJinKim HyeockJinKim force-pushed the feat/update-vfolder-cli branch from e042049 to 4403c54 Compare January 17, 2025 06:28
@HyeockJinKim HyeockJinKim added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit 4fc2b62 Jan 17, 2025
20 checks passed
@HyeockJinKim HyeockJinKim deleted the feat/update-vfolder-cli branch January 17, 2025 09:11
lablup-octodog pushed a commit that referenced this pull request Jan 17, 2025
@HyeockJinKim
feat(BA-519): Update SDK to retrieve and use IDs for VFolder API oper…
59854f6 
…ations instead of names (#3471)

Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3471
@lablup-octodog lablup-octodog mentioned this pull request Jan 17, 2025
Merged
lablup-octodog pushed a commit that referenced this pull request Jan 17, 2025
@HyeockJinKim
feat(BA-519): Update SDK to retrieve and use IDs for VFolder API oper…
5b415c9 
…ations instead of names (#3471)

Backported-from: main (24.12)
Backported-to: 24.03
Backport-of: 3471
@lablup-octodog lablup-octodog mentioned this pull request Jan 17, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2025
@lablup-octodog @HyeockJinKim
feat(BA-519): Update SDK to retrieve and use IDs for VFolder API oper…
016ea6b 
…ations instead of names (#3471) (#3486)

Co-authored-by: HyeockJinKim <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jan 17, 2025
@lablup-octodog @HyeockJinKim
feat(BA-519): Update SDK to retrieve and use IDs for VFolder API oper…
ac7e4a9 
…ations instead of names (#3471) (#3487)

Co-authored-by: HyeockJinKim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregataa fregataa fregataa approved these changes

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@HyeockJinKim HyeockJinKim

Labels
comp:client Related to Client component size:L 100~500 LoC
Projects
None yet
Milestone
24.03
Development

Successfully merging this pull request may close these issues.
2 participants
@HyeockJinKim @fregataa