Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Browsersync #352

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Remove Browsersync #352

merged 1 commit into from
Mar 18, 2024

Conversation

JeffreyATW
Copy link
Collaborator

@JeffreyATW JeffreyATW commented Feb 28, 2024

Browsersync does absolutely nothing besides making local dev setup difficult, so out it goes.

This PR also solves a problem where the WebSockets server and the vanilla HTTP server shared the same port. They will still share the same port (and somehow not cause issues) on prod, but locally the WS server will always operate on 3010 (and thanks to the removal of BS, the HTTP server will always operate on 3000).

In a future PR, I'll create only a single listener for both WS and HTTP.

@JeffreyATW JeffreyATW requested a review from holetse February 28, 2024 22:01
@JeffreyATW JeffreyATW mentioned this pull request Mar 8, 2024
Copy link
Member

@holetse holetse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 BrowserSync

@JeffreyATW JeffreyATW force-pushed the jeffrey/remove-browsersync branch from eddec01 to 1514840 Compare March 18, 2024 17:59
@JeffreyATW JeffreyATW merged commit 094c14d into develop Mar 18, 2024
1 check passed
@JeffreyATW JeffreyATW deleted the jeffrey/remove-browsersync branch March 18, 2024 18:05
@JeffreyATW
Copy link
Collaborator Author

A follow-up on this PR's description:

Only one server runs on prod. The express-ws package does the work of upgrading requests when necessary.

On dev, start.ts runs a secondary server to handle hot module reloading and other stuff, but allows the underlying app (also running its own server) to handle requests. Probably not necessary to merge into one - local dev works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants