Fixes Accept header to allow legacy and laminas-api-tools #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accepts: - application/vnd.laminas-api-tools.v1.config+json and legacy: - application/vnd.zfcampus.v1.config+json Signed-off-by: Michał Bundyra <[email protected]>
|
@weierophinney We might want apply this patch to all tags. This is migration issue. Not sure what we should do with Thoughts? |
snapshotpl
approved these changes
Apr 17, 2020
I had the same thought. I'm for keeping the wrong name and open an issue report to remove it with the next major version. |
weierophinney
requested changes
Apr 17, 2020
Signed-off-by: Michał Bundyra <[email protected]>
weierophinney
added a commit
that referenced
this pull request
Apr 23, 2020
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
added a commit
that referenced
this pull request
Apr 23, 2020
Forward port #54 Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On migration accept/content-type header has been changed to invalid value. Now we accepts both:
application/vnd.laminas-api-tools.v1.config+jsonapplication/vnd.zfcampus.v1.config+json