Psalm Support #60
Merged
Psalm Support #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this PR will be much easier to integrate once this issue is addressed/merged. |
|
Indeed, wanted to merge, but we need #59 first. |
Signed-off-by: andyo <[email protected]>
Signed-off-by: andyo <[email protected]>
Consistency between repos. Also adds config and view directories to scan. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Renames Psalm configuration file with .dist extension and adds indenting. - Applies automated and suggested fixes created by Psalm. - Creates initial Psalm baseline. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
They were not being flagged locally, which is concerning. I've indicated test assets should not be scanned (which was the bulk of them), and added a few more rigorous assertions where needed. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
The files are created during testing, prior to being included by the individual tests. Psalm does not know that, and assumes they are missing. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #58 and targets the 1.9.x branch.