Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHA CI Workflow #68

Merged
merged 8 commits into from
Jun 22, 2021
Merged

Switch to GHA CI Workflow #68

merged 8 commits into from
Jun 22, 2021

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Switch from Travis CI to use GitHub Actions according to: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.

This closes #64.

Gary Lockett added 3 commits June 2, 2021 13:37
Signed-off-by: Gary Lockett <[email protected]>
Signed-off-by: Gary Lockett <[email protected]>
@weierophinney weierophinney added the Enhancement New feature or request label Jun 21, 2021
@weierophinney weierophinney added this to the 1.10.0 milestone Jun 21, 2021
Somehow, the vendor/Test/ subdirectory was removed in the migration to Laminas, or in the initial work done for the GHA commit.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Applies both automated and manual fixes based on applying laminas-coding-standard v2.
- Updates the phpcs config to omit the VersioningModelTest, as it can lead to attempts to double-load a test asset class file.
- Removes the references to the "Int", "Float", and "Null" filters in the module configuration, as they should NEVER be used in PHP 7.3 and up.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Trailing slash leads to errors

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney weierophinney merged commit 69479f9 into laminas-api-tools:1.10.x Jun 22, 2021
@weierophinney weierophinney mentioned this pull request Jun 22, 2021
@internalsystemerror internalsystemerror deleted the feature/gha branch June 24, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to GHA CI workflow
2 participants