Ensure lockfile is created using PHP 7.3 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates lockfile using PHP 7.3 - Addresses new Psalm errors flagged - Provides fixes for as many as possible - Adds remaining (of `Mixed*` types, or `RedundantCondition` types that reflect inability to depend on documented types) to baseline Signed-off-by: Matthew Weier O'Phinney <[email protected]>
weierophinney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #74, the lockfile for the 1.10.x release branch is incorrectly using PHP 7.4 instead of PHP 7.3, which means that the non-unit-test CI jobs are failing due to an inability to install dependencies. This patch:
Mixed*types, orRedundantConditiontypes that reflect inability to depend on documented types) to baseline