Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 8.1 and remove deprecated /api/package feature #85

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

snapshotpl
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Allow install on PHP 8.1

@snapshotpl snapshotpl added the Enhancement New feature or request label Jun 3, 2022
@snapshotpl snapshotpl added this to the 1.11.0 milestone Jun 3, 2022
@snapshotpl
Copy link
Member Author

Fails on zfcampus/zf-deploy dependency, but it's abandoned. Any suggestion?

@Ocramius
Copy link
Member

Ocramius commented Jun 3, 2022

I see it's in require-dev: can we kill it?

@snapshotpl
Copy link
Member Author

Not sure. Looks like it's needed to build packages (optional feature), but I have never use it.
@ezimuel @weierophinney

@weierophinney
Copy link
Contributor

The admin includes a tab for creating a deployment package from your application - that's why the dependency exists here. We'd need to drop that tab from the UI package before dropping it here.

@Ocramius
Copy link
Member

Ocramius commented Jun 6, 2022

@snapshotpl there's now a PHP 8.1-compatible release of laminas-api-tools/api-tools 👍

@snapshotpl snapshotpl force-pushed the allow-php8.1 branch 2 times, most recently from 024c800 to ad7aaae Compare June 7, 2022 08:18
Signed-off-by: Witold Wasiczko <[email protected]>
@snapshotpl snapshotpl modified the milestones: 1.11.0, 2.0.0 Jun 7, 2022
@snapshotpl snapshotpl changed the base branch from 1.11.x to 2.0.x June 7, 2022 08:34
@snapshotpl snapshotpl changed the title Allow PHP 8.1 Allow PHP 8.1 and remove deprecated package feature Jun 7, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's 🚢 this. I'll release 2.0.0 with this

@Ocramius Ocramius changed the title Allow PHP 8.1 and remove deprecated package feature Allow PHP 8.1 and remove deprecated /api/package feature Jun 7, 2022
@Ocramius Ocramius self-assigned this Jun 7, 2022
@Ocramius Ocramius merged commit 6c97eae into laminas-api-tools:2.0.x Jun 7, 2022
@Ocramius
Copy link
Member

Ocramius commented Jun 7, 2022

Released 2.0.0, thanks @snapshotpl!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants