Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GHA CI workflow #25

Merged
merged 9 commits into from
Jun 23, 2021
Merged

Switch to GHA CI workflow #25

merged 9 commits into from
Jun 23, 2021

Conversation

internalsystemerror
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Switch from Travis CI to use GitHub Actions according to: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.

This closes #21.

@internalsystemerror internalsystemerror mentioned this pull request Jun 2, 2021
Merged
@internalsystemerror
Copy link
Member Author

internalsystemerror commented Jun 2, 2021 •
edited
Loading

I believe the only issue left with this is a connection issue. The tests pass locally so in my opinion it is related to something specific with GHA. It appears that it's not using the env variable TESTS_LAMINAS_API_TOOLS_DOCTRINE_EXTMONGODB_CONNECTSTRING defined in .github/workflows/continuous-integration.yml as can be seen by the error: https://github.com/laminas-api-tools/api-tools-doctrine/runs/2728441053?check_suite_focus=true#step:4:541
Edit: This is now resolved and a new issue has popped up.
All issues resolved.

switch to gha ci workflow
a7e5e98 
Signed-off-by: Gary Lockett <[email protected]>
@weierophinney weierophinney added the Enhancement New feature or request label Jun 23, 2021
@weierophinney weierophinney added this to the 2.4.0 milestone Jun 23, 2021
@weierophinney
qa: update phpunit and laminas-coding-standards dependencies
1c3412a 
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
qa: apply laminas-coding-standard v2
7bbfc7d 
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
qa: require at least 2.2.1 of laminas-hydrator
64f98d5 
Prior versions did not have a `Module` class, which causes tests to fail.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
fix: update minimum supported api-tools-rest to 1.3.2
157fa49 
First that supported Throwable for createApiProblemFromException().

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
fix: explode() and md5() expect strings, not integers
805da9e 
Cast values to string to ensure they do not raise errors.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
qa: bump minimum supported laminas-hydrator to 2.4.2
dc63b9d 
First with PHP 7.4 support.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
qa: bump minimum supported api-tools-hal version to 1.6.1
1cba1c2 
First version to properly support PHP 7.4.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney
qa: bump laminas-view minimum to 2.11.3
f0739f5 
Fixes a PHP 7.4 issue.

Signed-off-by: Matthew Weier O'Phinney <[email protected]>
@weierophinney weierophinney merged commit 10867e3 into laminas-api-tools:2.4.x Jun 23, 2021
@weierophinney weierophinney mentioned this pull request Jun 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Switch to GHA CI workflow
2 participants
@internalsystemerror @weierophinney