Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Psalm integration #26

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Provide Psalm integration #26

merged 2 commits into from
Jun 23, 2021

Conversation

weierophinney
Copy link
Contributor

This patch builds off the current 2.4.x state, which includes:

  • Usage of GHA for CI
  • Updating minimum PHP version to 7.3, and adding 8.0
  • Updating to laminas-coding-standard 2.3
  • Updating to PHPUnit 9.5

As such, this forms a better basis for adding Psalm support. This patch:

  • Adds Psalm (and its PHPUnit plugin) as a dev requirement, along with configuration.
  • Applies automated fixes and suggestions from Psalm, and creates the initial baseline.

Fixes #16
Replaces #18

@weierophinney weierophinney mentioned this pull request Jun 23, 2021
Closed
@weierophinney weierophinney added the Enhancement New feature or request label Jun 23, 2021
@weierophinney weierophinney added this to the 2.4.0 milestone Jun 23, 2021
@weierophinney weierophinney merged commit 59e498f into laminas-api-tools:2.4.x Jun 23, 2021
@weierophinney weierophinney deleted the feature/psalm-integration branch June 23, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Psalm integration
1 participant
@weierophinney