Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PHP 7.4 syntax #30

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

samsonasik
Copy link
Member

Signed-off-by: Abdul Malik Ikhsan [email protected]

Q A
QA yes

Description

Updated to use up to php 7.4 syntax and typed property (for private modifier only to keep BC) as now requirement is minimal php 7.4

Signed-off-by: Abdul Malik Ikhsan <[email protected]>
@samsonasik
Copy link
Member Author

All green 🎉

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samsonasik!

@Ocramius Ocramius self-assigned this Jan 19, 2022
@Ocramius Ocramius added the Enhancement New feature or request label Jan 19, 2022
@Ocramius Ocramius added this to the 1.6.0 milestone Jan 19, 2022
@Ocramius Ocramius merged commit b5a598b into laminas-api-tools:1.6.x Jan 19, 2022
@samsonasik samsonasik deleted the apply-php74 branch January 19, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants