-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer.json #40
Update composer.json #40
Conversation
Adds 8.1.0 as requirement for php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs:
- Updating
composer.lock
- Investigation of build failures
This looks like an incorrect docblock on that constructor (missing import or missin leading |
We probably need |
Yes, and we need a PHP 8.1 compatible version of |
|
Alternatively, we can configure CI to run 8.1 with |
|
Awesome, so what is left is:
Hopefully that will get us to green 😬 |
- updates psalm baseline
Ok, that last I suggest re-doing the commit with just |
Ok, looks like 7.3 cannot be supported together with 8.1 🤔 |
Ok, my suggestion to move this further/forward:
Not sure if further dependencies are problematic, but we'll have to see that as we move :-\ @samsonasik I could hold off a release until we also applied 7.4 type additions to this codebase, perhaps. |
- updates laminas/laminas-permission-rbac to ^3.2
|
@Ocramius I have updated it. But we have a lot of other work to do. laminas-oauth2, laminas-api-problem… |
What is the timeline for the task? |
@FTI-Herbert you tell me: send a patch? |
@Ocramius that's why we use a framework, so we don't have to do everything ourselves. |
WTF :-D You use a free framework, because you don't want to do everything by yourself? You know opensource? |
@FTI-Herbert the framework is developed by the community: if you use the framework, you are part of the community :) From your account activity, it doesn't seem that you are very familiar with how OSS works on github, but the general idea is "if you want to get something fixed, do it yourself, and everyone benefits from it". That's why I suggested to step up and help :) All you see around here has been built that way for multiple decades now 💪 |
I do not quite understand why you call in the big guns. In your(the laminas contributer community) opinion questions allowed only for contributing "member of the community"? Given this situation, i have to conclude unfortunately that, it is generally not worth the hassle to hold onto laminas. |
Adds 8.1.0 as requirement for php