Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json #40

Closed
wants to merge 6 commits into from
Closed

Update composer.json #40

wants to merge 6 commits into from

Conversation

jprangenbergde
Copy link

Adds 8.1.0 as requirement for php

Adds 8.1.0 as requirement for php
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs:

  • Updating composer.lock
  • Investigation of build failures

@Ocramius
Copy link
Member

Ocramius commented Jan 20, 2022

Error: Argument 1 of Laminas\ApiTools\OAuth2\Adapter\MongoAdapter::__construct expects Laminas\ApiTools\OAuth2\Adapter\MongoDB|array<string, int|string>, MongoDB provided (see https://psalm.dev/004)

This looks like an incorrect docblock on that constructor (missing import or missin leading \ in front of the type)

@Ocramius Ocramius mentioned this pull request Jan 20, 2022
Closed
@Ocramius
Copy link
Member

We probably need laminas/coding-standard:~2.3.0 to get a successful PHP 8.1 installation.

@jprangenbergde
Copy link
Author

We probably need laminas/coding-standard:~2.3.0 to get a successful PHP 8.1 installation.

Yes, and we need a PHP 8.1 compatible version of laminas-api-tools/api-tools-oauth2. But this package requires laminas/laminas-test which requires laminas/laminas-console which is readonly and not compatible to PHP 8.1.

@froschdesign
Copy link
Member

@jprangenbergde

But this package requires laminas/laminas-test which requires laminas/laminas-console

Please check version 4.0.0 of laminas-test.

@Ocramius
Copy link
Member

Alternatively, we can configure CI to run 8.1 with --ignore-platform-reqs for now? 🤔

@jprangenbergde
Copy link
Author

Alternatively, we can configure CI to run 8.1 with --ignore-platform-reqs for now? 🤔

https://github.com/laminas-api-tools/api-tools-mvc-auth/pull/40/files#diff-3fb49ad00d3736f1ca8276f568f5d8bbe8c1604f6187ab5ecf921e1012f47c98

@Ocramius
Copy link
Member

Awesome, so what is left is:

  • fixing that docblock
  • vendor/bin/psalm --no-cache --update-baseline
  • bumping laminas/laminas-http minimum version (or introducing a conflict with older versions)

Hopefully that will get us to green 😬

@Ocramius
Copy link
Member

Ok, that last composer.lock update was too big (updated everything 😁)

I suggest re-doing the commit with just composer update laminas/laminas-http

@Ocramius
Copy link
Member

Ok, looks like 7.3 cannot be supported together with 8.1 🤔

@Ocramius
Copy link
Member

Ok, my suggestion to move this further/forward:

  • drop PHP 7.3 support (only 7.4 onwards)
  • bump laminas/laminas-permissions-rbac to its latest version

Not sure if further dependencies are problematic, but we'll have to see that as we move :-\

@samsonasik I could hold off a release until we also applied 7.4 type additions to this codebase, perhaps.

@Ocramius Ocramius added this to the 1.7.0 milestone Jan 20, 2022
- updates laminas/laminas-permission-rbac to ^3.2
@Ocramius
Copy link
Member

laminas/laminas-permissions-rbac needs upgrading here

@jprangenbergde
Copy link
Author

jprangenbergde commented Jan 24, 2022

laminas/laminas-permissions-rbac

@Ocramius I have updated it. But we have a lot of other work to do. laminas-oauth2, laminas-api-problem…

@ghost
Copy link

ghost commented Apr 25, 2022

What is the timeline for the task?

@Ocramius
Copy link
Member

@FTI-Herbert you tell me: send a patch?

@ghost
Copy link

ghost commented Apr 25, 2022

@Ocramius that's why we use a framework, so we don't have to do everything ourselves.

@jprangenbergde
Copy link
Author

@Ocramius that's why we use a framework, so we don't have to do everything ourselves.

WTF :-D You use a free framework, because you don't want to do everything by yourself? You know opensource?

@Ocramius
Copy link
Member

@FTI-Herbert the framework is developed by the community: if you use the framework, you are part of the community :)

From your account activity, it doesn't seem that you are very familiar with how OSS works on github, but the general idea is "if you want to get something fixed, do it yourself, and everyone benefits from it".

That's why I suggested to step up and help :)

All you see around here has been built that way for multiple decades now 💪

@ghost
Copy link

ghost commented Apr 27, 2022

I do not quite understand why you call in the big guns.
I just asked one simple question after 3 month of inaction.
Even dependent on laminas we try to keep up with current php versions, which is by no means a trivial objective.

In your(the laminas contributer community) opinion questions allowed only for contributing "member of the community"?
Well, in that case, we should also look at ways of making better use of our time and moving in a different direction in general.

Given this situation, i have to conclude unfortunately that, it is generally not worth the hassle to hold onto laminas.
Of course, be on one's high horse, that doesn't bother you.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants