Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

Remove laminas/laminas-servicemanager dependency #33

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Remove laminas/laminas-servicemanager dependency #33

merged 1 commit into from
Jul 15, 2024

Conversation

marcelthole
Copy link
Contributor

Q A
New Feature yes

Description

solve #27
Relates to #22

Did the same testrun on the current branch with use Psr\Container\ContainerInterface; use Psr\Container\NotFoundExceptionInterface; and without the servicemanager dependency

#20 (comment)

Created cipher of type Laminas\Crypt\BlockCipher
Plugin manager implements: Psr\Container\ContainerInterface
Plugin manager DOES implement Psr\Container\ContainerInterface

@Ocramius Ocramius added this to the 3.12.0 milestone Jul 15, 2024
@Ocramius Ocramius self-assigned this Jul 15, 2024
Ocramius
Ocramius approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcelthole

@Ocramius Ocramius merged commit ceab630 into laminas:3.12.x Jul 15, 2024
12 of 13 checks passed
@marcelthole marcelthole mentioned this pull request Jul 15, 2024
Merged
@gsteel gsteel linked an issue Jul 17, 2024 that may be closed by this pull request
Dependency of laminas/laminas-servicemanager can be removed #27
Closed
@gsteel gsteel mentioned this pull request Jul 17, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement
Projects
None yet
Milestone
3.12.0
Development

Successfully merging this pull request may close these issues.

Dependency of laminas/laminas-servicemanager can be removed
2 participants
@marcelthole @Ocramius