-
-
Notifications
You must be signed in to change notification settings - Fork 23
Strict and native Types + PHP8.0 Drop + PHPUnit Upgrade [BC Break] #35
Conversation
13209d4
to
4c3448a
Compare
Signed-off-by: Marcel Thole <[email protected]>
Signed-off-by: Marcel Thole <[email protected]>
Signed-off-by: Marcel Thole <[email protected]>
44a26c7
to
e601df1
Compare
Signed-off-by: Marcel Thole <[email protected]>
Signed-off-by: Marcel Thole <[email protected]>
Signed-off-by: Marcel Thole <[email protected]>
e601df1
to
ffaa151
Compare
Note: we need to open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - I can't see any problematic changes other than the obvious BC breaks with native types. I'd approve if I was more familiar with this component, but I'll leave that to other members of the TSC 👍
/** | ||
* Get certificate string | ||
* | ||
* @return string | ||
*/ | ||
public function getCertificate() | ||
{ | ||
return $this->certificateString; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removal should probably be documented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there something like a changelog or will it be manually filled with a release of a new tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just searched - There's no mention of it in any docs or any usage anywhere else, not even in tests.
As it's not mentioned in the docs, perhaps all that is required is a mention in the release notes. I don't think this is a big deal👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to add stuff like this to the milestone manually using keep-a-changelog format.
did that a bunch of times for laminas-cache and related adapters.
https://github.com/laminas/laminas-cache/releases/tag/4.0.0
This component was voted to be abandoned but we failed to follow up and mark it as such. https://github.com/laminas/technical-steering-committee/blob/main/meetings/minutes/2023-11-06-TSC-Minutes.md#decisions |
Allow psr container 2
Signed-off-by: Marcel Thole <[email protected]>
Description
As mentioned in #34 (comment) we could use the chance and add strict types and native types for the next release if we have already BC Breaks.
So here some (mostly automated) changes:
What is missing?