[3.6] Regression: ArrayObject with protected ARRAY_AS_PROPS cannot be serialized anymore #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slamdunk
force-pushed
the
array_object_as_props_bug
branch
from
8950302 to
3c31580
Compare
… serialized anymore Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Slamdunk
force-pushed
the
array_object_as_props_bug
branch
from
3c31580 to
e330333
Compare
Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Ocramius
reviewed
Nov 29, 2021
There was a problem hiding this comment.
I don't have the context to review this, sorry.
I'd defer to @weierophinney, but you can pretty much assume that the BC break is not intentional, so a 3.6.x release is very much welcome, if it fixes the BC issue.
| @@ -92,7 +92,7 @@ public function __isset($key) | |||
| } | |||
|
|
|||
| if (in_array($key, $this->protectedProperties)) { | |||
| throw new Exception\InvalidArgumentException('$key is a protected property, use a different key'); | |||
| throw new Exception\InvalidArgumentException("$key is a protected property, use a different key"); | |||
There was a problem hiding this comment.
Oh wow, these were changed by CS? :O
There was a problem hiding this comment.
It's 8 years these LoC are here in this very form 😄
Ocramius
added
Awaiting Maintainer Response
BC Break
Bug
|
Here's the bug explained: child class properties are serialized before parent's ones. |
weierophinney
requested changes
Nov 30, 2021
Co-authored-by: Matthew Weier O'Phinney <[email protected]> Signed-off-by: Filippo Tessarotto <[email protected]>
Signed-off-by: Filippo Tessarotto <[email protected]>
Slamdunk
force-pushed
the
array_object_as_props_bug
branch
from
a387ed9 to
d844fcf
Compare
Signed-off-by: Filippo Tessarotto <[email protected]>
Slamdunk
force-pushed
the
array_object_as_props_bug
branch
from
0d68392 to
724894b
Compare
weierophinney
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In our app we serialize
Laminas\Session\Storage\ArrayStorageobjects as defined in its package:https://github.com/laminas/laminas-session/blob/2.12.0/src/Storage/ArrayStorage.php
Which uses
ArrayObject::ARRAY_AS_PROPSalongside a protected property$isImmutable.Such serialization broke after #35 has been released in
3.6minor.The proposed test indeed passes on
3.5.xbranch.I hope to find a fix soon, in the meantime I'd like to know if such BC Break was intended or not, ping @weierophinneySurely a BC Break that deserves a bugfix release, imho.