checking "broken" and "skipped" statuses moved out of executeTest() #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molotkovserguei
changed the title
molotkovserguei
changed the title
|
возврат &models.Result{} был исправлен в коммите 13e5ca4 Перенос самой проверки статусов "broken" and "skipped" ожидает проверки. Кто-то вероятно должен проверить и разрешить слияние. Кто именно - здесь не видно. Посмотрите пожалуйста. Реквест очень маленький. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runner/runner.go
The executeTest() function returns an empty &models.Result{Test: v} for the "broken" and "skipped" statuses, which is ignored outside of functions. At the same time, the "focus" and "broken" statuses are processed before the executeTest(). There is a reason to move the status processing closer to each other.
Функция executeTest() возвращает по статусам "broken" and "skipped" пустой ответ &models.Result{Test: v}, который далее ингорируется. В тоже время обработка статусов "focus" и "broken" происходит перед вызовом executeTest(). Есть повод перенести обработку статусов ближе друг к другу.