-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support bm25 milvus function #33
Conversation
Signed-off-by: ChengZi <[email protected]>
@zc277584121 running the
Is this expected or something is wrong with my settings? |
@ohadeytan The full text search feature is so far not supported in Milvus-Lite. It says |
Signed-off-by: ChengZi <[email protected]>
Signed-off-by: ChengZi <[email protected]>
Signed-off-by: ChengZi <[email protected]>
here is document, which is waiting final reviewing, https://github.com/zc277584121/bootcamp/blob/langchain_doc/bootcamp/tutorials/integration/langchain/full_text_search_with_langchain.ipynb |
What if I want to use seperate search prompt for keyword and semantic, this hybird retriever wrapper isnt flexiblefor that i think |
@janaki-sasidhar Do you mean this kind of case:
If so, can you explain what is its scenario, any infomation will be appreciate |
This PR introduced some major refactors:
BaseMilvusBuiltInFunction
, which is a light wrapper of Milvus Function.Bm25BuiltInFunction
extended fromBaseMilvusBuiltInFunction
, which includes the MilvusFunctionType.BM25
settings and the configs of Milvus analyzer. We can use thisBm25BuiltInFunction
to implement Full text search in MilvusFunctionType.TEXTEMBEDDING
example). So in the future we can implement more subclass fromBaseMilvusBuiltInFunction
to support the text-in functions in Milvus.test_builtin_bm25_function()
. Simply speaking, we can pass in any customized Langchain embedding functions or milvus built-in functions to the Milvus class initialization function to build multi index fields in Milvus.Some use case examples will be like these:
or with multi embedding fields and bm25 function: