Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape directory to prevent \n on Windows directory name to fail on Pathlib + Tests #4101

Merged
merged 5 commits into from
Oct 14, 2024
Merged

fix: escape directory to prevent \n on Windows directory name to fail on Pathlib + Tests #4101

merged 5 commits into from
Oct 14, 2024

Commits on Oct 14, 2024

  1. 📝 (utils.py): add format_directory_path function to properly escape a… 

    …nd format directory paths for consistency and validity
    @Cristhianzl @ogabrielluiz
    Cristhianzl authored and ogabrielluiz committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e71d467 View commit details
    Browse the repository at this point in the history

  2. ✨ (test_format_directory_path.py): add unit tests for the format_dire… 

    …ctory_path function to ensure correct formatting of directory paths

📝 (test_format_directory_path.py): add documentation and examples for different types of directory paths in the unit tests to improve code readability and maintainability
    @Cristhianzl @ogabrielluiz
    Cristhianzl authored and ogabrielluiz committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5c11f0c View commit details
    Browse the repository at this point in the history

  3. 🐛 (utils.py): fix the incorrect replacement of backslashes with newli… 

    …ne characters in the format_directory_path function

📝 (test_rewrite_file_path.py): update test cases and function names to reflect the changes made in the format_directory_path function in utils.py
    @Cristhianzl @ogabrielluiz
    Cristhianzl authored and ogabrielluiz committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7915fa5 View commit details
    Browse the repository at this point in the history

  4. 🐛 (test_format_directory_path.py): update parameter name from 'path' … 

    …to 'input_path' for clarity and consistency

📝 (test_format_directory_path.py): improve test case descriptions and handle newline characters in paths correctly
    @Cristhianzl @ogabrielluiz
    Cristhianzl authored and ogabrielluiz committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    21b1a42 View commit details
    Browse the repository at this point in the history

  5. [autofix.ci] apply automated fixes

    @autofix-ci
    autofix-ci[bot] authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    27d4d9d View commit details
    Browse the repository at this point in the history