Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Fix some ruff rules for private access (SLF) #4139

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Oct 14, 2024

Fixing but not enforcing at the moment since a lot of attributes can't be changed in Component

Renamed:

  • Vertex._added_message
  • Vertex._custom_component
Vertex._built
  • Vertex._built_object
  • Vertex._built_result
  • Vertex._data
  • Vertex._raw_params
  • Vertex._has_cycle_edges
  • Vertex._build_params()
  • Vertex._parse_data()
  • Vertex._built_object_repr()
  • Vertex._finalize_build()
  • Graph._has_session_id_vertices
  • StoreService._get()
  • ChatService._async_cache_locks
  • build_vector_store._is_cached_vector_store_checked

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 14, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a dangerous one. hahaha

src/backend/base/langflow/api/utils.py Show resolved Hide resolved
@cbornet cbornet force-pushed the ruff-rules-slf branch 4 times, most recently from fcc0b29 to 2aabe76 Compare October 14, 2024 21:37
@cbornet
Copy link
Collaborator Author

cbornet commented Oct 14, 2024

This is a dangerous one. hahaha

Yes, I'm counting on you to know the places where there are traps like define_vertices_lists 😄 . And tests should also catch potential issues.

@cbornet
Copy link
Collaborator Author

cbornet commented Oct 15, 2024

Can't rename Vertex._data to Vertex.data as the latter already exists (and Vertex.data is equal to Vertex._data["data"] which is a bit confusing...). So I renamed it to Vertex.full_data.

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 22, 2024
@cbornet cbornet force-pushed the ruff-rules-slf branch 3 times, most recently from 10989d7 to d7a5f4a Compare October 22, 2024 22:06
@cbornet cbornet enabled auto-merge (squash) October 22, 2024 22:08
@cbornet cbornet force-pushed the ruff-rules-slf branch 2 times, most recently from 45377b5 to 6f45b59 Compare October 22, 2024 22:27
@cbornet cbornet merged commit f44aca5 into langflow-ai:main Oct 22, 2024
27 checks passed
@cbornet cbornet deleted the ruff-rules-slf branch October 23, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants