fix: cartesian product warning in delete_folder #4224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
dhlidongming
changed the title
github-actions
bot
added
bug
ogabrielluiz
force-pushed
the
fix/cartesian-product-warning
branch
from
a35a663
to
4f87df5
Compare
ogabrielluiz
force-pushed
the
fix/cartesian-product-warning
branch
from
410b08a
to
2946f55
Compare
ogabrielluiz
force-pushed
the
fix/cartesian-product-warning
branch
from
2946f55
to
8ebd6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a cartesian product warning in
delete_folderby replacing Folder.user_id with Flow.user_id for correct filtering.The query previously used Folder.user_id, leading to the warning:
SAWarning: SELECT statement has a cartesian product between FROM element(s) "flow" and FROM element "folder".