-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dockerfiles and docker-build workflows to fix releases #4317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
enhancement
New feature or request
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Oct 29, 2024
github-actions
bot
added
ignore-for-release
and removed
enhancement
New feature or request
labels
Oct 30, 2024
Nightly release green https://github.com/langflow-ai/langflow/actions/runs/11597772978 |
ogabrielluiz
requested changes
Oct 30, 2024
ogabrielluiz
approved these changes
Oct 30, 2024
ogabrielluiz
force-pushed
the
test-nightly
branch
from
October 31, 2024 01:05
4c56c7c
to
52af7ed
Compare
jordanrfrazier
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge. Nice fixes
ogabrielluiz
changed the title
chore: Unblock Nightlies
chore: update dockerfiles and docker-build workflows to fix releases
Oct 31, 2024
ogabrielluiz
force-pushed
the
test-nightly
branch
from
October 31, 2024 11:15
52af7ed
to
2a4151a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ignore-for-release
lgtm
This PR has been approved by a maintainer
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the CI/CD workflows and Docker build configurations to improve reliability and maintainability. Key changes include adding environment setup steps, enhancing error handling, unifying version update scripts, and modifying Dockerfile mounts and paths.
Workflow Improvements:
docker-build.yml
workflow. (.github/workflows/docker-build.yml
)docker-build.yml
workflow. (.github/workflows/docker-build.yml
)Dockerfile Updates:
uv
. (docker/build_and_push_base.Dockerfile
) [1] [2]docker/build_and_push_base.Dockerfile
)Script Enhancements:
update_pyproject_combined.py
to handle both base and main updates in a single run. (scripts/ci/update_pyproject_combined.py
)Other Changes:
nightly_build.yml
workflow to improve script robustness. (.github/workflows/nightly_build.yml
)release_nightly.yml
workflow. (.github/workflows/release_nightly.yml
)