Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dockerfiles and docker-build workflows to fix releases #4317

Merged
merged 19 commits into from
Oct 31, 2024

Conversation

phact
Copy link
Collaborator

@phact phact commented Oct 29, 2024

This pull request includes several updates to the CI/CD workflows and Docker build configurations to improve reliability and maintainability. Key changes include adding environment setup steps, enhancing error handling, unifying version update scripts, and modifying Dockerfile mounts and paths.

Workflow Improvements:

  • Environment Setup: Added a new step to set up the environment in the docker-build.yml workflow. (.github/workflows/docker-build.yml)
  • Error Handling: Enhanced error handling for version extraction in the docker-build.yml workflow. (.github/workflows/docker-build.yml)

Dockerfile Updates:

  • Mounting Project Files: Updated the Dockerfile to mount additional project files required for building with uv. (docker/build_and_push_base.Dockerfile) [1] [2]
  • Virtual Environment Path: Modified the Dockerfile to use the virtual environment at the root due to workspace requirements. (docker/build_and_push_base.Dockerfile)

Script Enhancements:

  • Unified Update Script: Introduced a new script update_pyproject_combined.py to handle both base and main updates in a single run. (scripts/ci/update_pyproject_combined.py)

Other Changes:

  • Shell Options: Updated the shell options in the nightly_build.yml workflow to improve script robustness. (.github/workflows/nightly_build.yml)
  • Workflow Cleanup: Commented out the unsupported Docker build step in the release_nightly.yml workflow. (.github/workflows/release_nightly.yml)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@phact phact changed the title Unblock Nightlies chore: Unblock Nightlies Oct 30, 2024
@github-actions github-actions bot added ignore-for-release and removed enhancement New feature or request labels Oct 30, 2024
@phact
Copy link
Collaborator Author

phact commented Oct 30, 2024

.github/workflows/docker-build.yml Show resolved Hide resolved
.github/workflows/docker-build.yml Show resolved Hide resolved
.github/workflows/docker-build.yml Show resolved Hide resolved
docker/build_and_push_base.Dockerfile Show resolved Hide resolved
docker/build_and_push_base.Dockerfile Show resolved Hide resolved
@phact phact self-assigned this Oct 30, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 30, 2024
Copy link
Collaborator

@jordanrfrazier jordanrfrazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge. Nice fixes

@ogabrielluiz ogabrielluiz changed the title chore: Unblock Nightlies chore: update dockerfiles and docker-build workflows to fix releases Oct 31, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) October 31, 2024 11:15
@ogabrielluiz ogabrielluiz merged commit c1097d2 into main Oct 31, 2024
9 checks passed
@ogabrielluiz ogabrielluiz deleted the test-nightly branch October 31, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants