Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pdf parsing, pass as str instead of posix path #4448

Merged
merged 18 commits into from
Nov 8, 2024
Merged

Conversation

erichare
Copy link
Collaborator

@erichare erichare commented Nov 7, 2024

This Pull Request updates our PDF parser to fix an issue with PosixPath's needing to be converted to str

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 7, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
@erichare erichare changed the title FIX: PyMuPDF for parsing, pass as str instead of posix path FIX: PDF parsing, pass as str instead of posix path Nov 7, 2024
@italojohnny italojohnny changed the title FIX: PDF parsing, pass as str instead of posix path fix: pdf parsing, pass as str instead of posix path Nov 7, 2024
@github-actions github-actions bot added the bug Something isn't working label Nov 7, 2024
@erichare erichare enabled auto-merge (squash) November 7, 2024 15:54
@erichare erichare enabled auto-merge (squash) November 7, 2024 18:47
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 7, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @erichare !

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 7, 2024
erichare and others added 3 commits November 7, 2024 13:21
…ss to include IntInput for concurrency_multithreading to control the number of workers for parallel processing. This enhancement allows for better control and optimization of processing tasks.
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 8, 2024
….3.10 to version 0.3.12 to ensure compatibility and leverage new features
@erichare erichare closed this Nov 8, 2024
auto-merge was automatically disabled November 8, 2024 15:07

Pull request was closed

@erichare erichare reopened this Nov 8, 2024
@erichare erichare enabled auto-merge (squash) November 8, 2024 15:09
Copy link

codspeed-hq bot commented Nov 8, 2024

CodSpeed Performance Report

Merging #4448 will create unknown performance changes

Comparing bugfix-pdf-parsing (187e381) with main (9827463)

Summary

🆕 15 new benchmarks

Benchmarks breakdown

Benchmark main bugfix-pdf-parsing Change
🆕 test_create_starter_projects N/A 401.9 ms N/A
🆕 test_get_and_cache_all_types_dict N/A 1 ms N/A
🆕 test_initialize_services N/A 139.7 ms N/A
🆕 test_initialize_super_user N/A 142.6 ms N/A
🆕 test_load_flows N/A 1.3 ms N/A
🆕 test_setup_llm_caching N/A 1.6 ms N/A
🆕 test_build_flow N/A 691.4 ms N/A
🆕 test_build_flow_from_request_data N/A 696.6 ms N/A
🆕 test_get_all N/A 515.4 ms N/A
🆕 test_invalid_run_with_input_type_chat N/A 16.6 ms N/A
🆕 test_starter_projects N/A 1.2 s N/A
🆕 test_successful_run_with_input_type_any N/A 494.7 ms N/A
🆕 test_successful_run_with_input_type_text N/A 450.3 ms N/A
🆕 test_successful_run_with_output_type_any N/A 452.1 ms N/A
🆕 test_successful_run_with_output_type_debug N/A 407.1 ms N/A

@erichare erichare merged commit a4863bb into main Nov 8, 2024
29 checks passed
@erichare erichare deleted the bugfix-pdf-parsing branch November 8, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants