-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pdf parsing, pass as str instead of posix path #4448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Nov 7, 2024
Cristhianzl
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
erichare
changed the title
FIX: PyMuPDF for parsing, pass as str instead of posix path
FIX: PDF parsing, pass as str instead of posix path
Nov 7, 2024
italojohnny
changed the title
FIX: PDF parsing, pass as str instead of posix path
fix: pdf parsing, pass as str instead of posix path
Nov 7, 2024
ogabrielluiz
requested changes
Nov 7, 2024
ogabrielluiz
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @erichare !
LGTM
ogabrielluiz
force-pushed
the
bugfix-pdf-parsing
branch
from
November 7, 2024 20:39
35d4af4
to
2e3c900
Compare
…ss to include IntInput for concurrency_multithreading to control the number of workers for parallel processing. This enhancement allows for better control and optimization of processing tasks.
dosubot
bot
added
size:L
This PR changes 100-499 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
Nov 8, 2024
….3.10 to version 0.3.12 to ensure compatibility and leverage new features
…ns greater than or equal to 0.3.12 for compatibility reasons
CodSpeed Performance ReportMerging #4448 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates our PDF parser to fix an issue with PosixPath's needing to be converted to str