Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: standardize toolbar select item widths and improve alignment #4539

Merged
merged 19 commits into from
Nov 13, 2024

Conversation

Cristhianzl
Copy link
Collaborator

@Cristhianzl Cristhianzl commented Nov 12, 2024

This pull request includes several changes to the NodeToolbarComponent and SelectItem components in the frontend. The main focus is on improving the styling and layout of the toolbar and select items.

Improvements to NodeToolbarComponent:

  • Added className="w-52" to multiple SelectItem components to standardize their width.
  • Modified the SelectContent component to adjust its position and scaling based on the scale value.

Styling adjustments in SelectItem:

  • Changed padding from pl-3 pr-2 to px-3 for better alignment.

…ove consistency and readability

📝 (nodeToolbarComponent/index.tsx): Refactor SelectItem components to include consistent width styling for better alignment and visual appeal
…ng 'm-auto' class to improve visual presentation.
@Cristhianzl Cristhianzl self-assigned this Nov 12, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Nov 12, 2024
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Nov 12, 2024
…ons in GenericNode component

🔧 (nodeToolbarComponent/index.tsx): Pass setOpenShowMoreOptions function to toggle show more options in NodeToolbarComponent
📝 (components/index.ts): Update nodeToolbarPropsType to include setOpenShowMoreOptions function for better type checking
…better UI consistency and alignment in the Node Toolbar Component.
@Cristhianzl Cristhianzl enabled auto-merge (squash) November 12, 2024 19:47
… from SelectItem components to improve code readability and reduce redundancy.
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@ogabrielluiz ogabrielluiz enabled auto-merge (squash) November 13, 2024 03:57
…ove consistency and readability

📝 (nodeToolbarComponent/index.tsx): Refactor SelectItem components to include consistent width styling for better alignment and visual appeal
…ng 'm-auto' class to improve visual presentation.
…ons in GenericNode component

🔧 (nodeToolbarComponent/index.tsx): Pass setOpenShowMoreOptions function to toggle show more options in NodeToolbarComponent
📝 (components/index.ts): Update nodeToolbarPropsType to include setOpenShowMoreOptions function for better type checking
…better UI consistency and alignment in the Node Toolbar Component.
… from SelectItem components to improve code readability and reduce redundancy.
…"Document Q&A" instead of "Document QA" for consistency

📝 (Basic Prompting.spec.ts, Blog Writer.spec.ts, Document QA.spec.ts, Dynamic Agent.spec.ts, Hierarchical Agent.spec.ts, Memory Chatbot.spec.ts, Sequential Task Agent.spec.ts, Simple Agent.spec.ts, Travel Planning Agent.spec.ts, Vector Store.spec.ts): Remove 'skip' from test descriptions to enable running the tests.
…un tests on a single shard for simplicity

📝 (typescript_test.yml): Comment out unused test commands to improve readability and reduce confusion
✅ (starter-projects.spec.ts): Remove skip from test case to ensure it is executed as intended
@Cristhianzl Cristhianzl merged commit 654d481 into main Nov 13, 2024
18 checks passed
@Cristhianzl Cristhianzl deleted the cz/fix-toolbar branch November 13, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants