-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: standardize toolbar select item widths and improve alignment #4539
Merged
+45
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove consistency and readability 📝 (nodeToolbarComponent/index.tsx): Refactor SelectItem components to include consistent width styling for better alignment and visual appeal
…ng 'm-auto' class to improve visual presentation.
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
javascript
Pull requests that update Javascript code
labels
Nov 12, 2024
github-actions
bot
added
refactor
Maintenance tasks and housekeeping
and removed
refactor
Maintenance tasks and housekeeping
labels
Nov 12, 2024
…ons in GenericNode component 🔧 (nodeToolbarComponent/index.tsx): Pass setOpenShowMoreOptions function to toggle show more options in NodeToolbarComponent 📝 (components/index.ts): Update nodeToolbarPropsType to include setOpenShowMoreOptions function for better type checking
…better UI consistency and alignment in the Node Toolbar Component.
… from SelectItem components to improve code readability and reduce redundancy.
lucaseduoli
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ogabrielluiz
force-pushed
the
cz/fix-toolbar
branch
from
November 13, 2024 03:46
89bf1a9
to
e4d80e4
Compare
…ove consistency and readability 📝 (nodeToolbarComponent/index.tsx): Refactor SelectItem components to include consistent width styling for better alignment and visual appeal
…ng 'm-auto' class to improve visual presentation.
…ons in GenericNode component 🔧 (nodeToolbarComponent/index.tsx): Pass setOpenShowMoreOptions function to toggle show more options in NodeToolbarComponent 📝 (components/index.ts): Update nodeToolbarPropsType to include setOpenShowMoreOptions function for better type checking
…better UI consistency and alignment in the Node Toolbar Component.
… from SelectItem components to improve code readability and reduce redundancy.
ogabrielluiz
force-pushed
the
cz/fix-toolbar
branch
from
November 13, 2024 04:19
e4d80e4
to
948b5a8
Compare
…"Document Q&A" instead of "Document QA" for consistency 📝 (Basic Prompting.spec.ts, Blog Writer.spec.ts, Document QA.spec.ts, Dynamic Agent.spec.ts, Hierarchical Agent.spec.ts, Memory Chatbot.spec.ts, Sequential Task Agent.spec.ts, Simple Agent.spec.ts, Travel Planning Agent.spec.ts, Vector Store.spec.ts): Remove 'skip' from test descriptions to enable running the tests.
…un tests on a single shard for simplicity 📝 (typescript_test.yml): Comment out unused test commands to improve readability and reduce confusion ✅ (starter-projects.spec.ts): Remove skip from test case to ensure it is executed as intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
javascript
Pull requests that update Javascript code
lgtm
This PR has been approved by a maintainer
refactor
Maintenance tasks and housekeeping
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
NodeToolbarComponent
andSelectItem
components in the frontend. The main focus is on improving the styling and layout of the toolbar and select items.Improvements to
NodeToolbarComponent
:className="w-52"
to multipleSelectItem
components to standardize their width.SelectContent
component to adjust its position and scaling based on thescale
value.Styling adjustments in
SelectItem
:pl-3 pr-2
topx-3
for better alignment.