Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use starting value as local solution for presolve (with changes) #219

Merged
merged 6 commits into from
Sep 24, 2022

Conversation

harshangrjn
Copy link
Collaborator

@blegat Made a few minor renaming modifications to your PR (#218). Since I can't push the changes there, creating a separate one here. Tested a bit but looks like it doesn't run with starting points for both linear and NL objective (may be I am missing something). For example, try running examples/run_examples.jl. nlp1 and nlp3 are the NLPs. This error shows up for nlp3:

ERROR: LoadError: No nonlinear objective.
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] eval_objective
    @ ~/.julia/packages/MathOptInterface/MMUy6/src/Nonlinear/ReverseAD/mathoptinterface_api.jl:167 [inlined]
  [3] eval_objective(evaluator::MathOptInterface.Nonlinear.Evaluator{MathOptInterface.Nonlinear.ReverseAD.NLPEvaluator}, x::Vector{Float64})
    @ MathOptInterface.Nonlinear ~/.julia/packages/MathOptInterface/MMUy6/src/Nonlinear/evaluator.jl:116

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #219 (1fb1053) into master (de2b6ca) will decrease coverage by 0.02%.
The diff coverage is 89.58%.

❗ Current head 1fb1053 differs from pull request most recent head 7765919. Consider uploading reports for the commit 7765919 to get more accurate results

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
- Coverage   87.26%   87.24%   -0.03%     
==========================================
  Files          16       16              
  Lines        2977     2988      +11     
==========================================
+ Hits         2598     2607       +9     
- Misses        379      381       +2     
Impacted Files Coverage Δ
src/nlexpr.jl 91.44% <ø> (-0.03%) ⬇️
src/log.jl 90.16% <75.00%> (ø)
src/main_algorithm.jl 85.26% <82.60%> (-0.09%) ⬇️
src/MOI_wrapper/MOI_wrapper.jl 84.18% <100.00%> (ø)
src/bounding_model.jl 87.93% <100.00%> (ø)
src/heuristics.jl 73.07% <100.00%> (ø)
src/multilinear.jl 86.56% <100.00%> (ø)
src/presolve.jl 85.09% <100.00%> (-0.10%) ⬇️
src/solver_options.jl 100.00% <100.00%> (ø)
src/utility.jl 87.79% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@blegat
Copy link
Contributor

blegat commented Sep 12, 2022

Oops, should be fixed in #218

@harshangrjn harshangrjn merged commit c6da8b9 into master Sep 24, 2022
@harshangrjn harshangrjn deleted the use_start_as_local branch September 24, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants