-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JuMP v0.23 and switch from Cbc to HiGHS #232
Conversation
I did notice that JuMP got back into the package deps. The objective of this PR was to remove it, #207 |
It's only in the test dependencies |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
+ Coverage 91.68% 92.31% +0.62%
==========================================
Files 20 20
Lines 1961 1991 +30
==========================================
+ Hits 1798 1838 +40
+ Misses 163 153 -10
Continue to review full report at Codecov.
|
It's nice to see that HiGHS passes all the tests. |
MOIU.attach_optimizer(m) | ||
bm = JuMP.backend(m) | ||
options = bm.optimizer.model.optimizer.options | ||
options = JuMP.unsafe_backend(m).options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks to me this was the only breaking change that impacted Juniper in the move from MOI v0.10 to 1.0? Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a change in how JuMP manages its backend.
I don't think we ever encouraged people to call .optimizer.model.optimizer
, so this is arguably a bug-fix. We should have used direct_model
if we cared about the backend. The new unsafe_backend
provides a nice way to get the inner model for cases like this.
No description provided.