Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JuMP v0.23 and switch from Cbc to HiGHS #232

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Update to JuMP v0.23 and switch from Cbc to HiGHS #232

merged 4 commits into from
Feb 28, 2022

Conversation

odow
Copy link
Collaborator

@odow odow commented Feb 26, 2022

No description provided.

@ccoffrin
Copy link
Member

I did notice that JuMP got back into the package deps. The objective of this PR was to remove it, #207

@blegat
Copy link
Collaborator

blegat commented Feb 27, 2022

It's only in the test dependencies

test/functions.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #232 (9dd85ae) into master (ec81a10) will increase coverage by 0.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   91.68%   92.31%   +0.62%     
==========================================
  Files          20       20              
  Lines        1961     1991      +30     
==========================================
+ Hits         1798     1838      +40     
+ Misses        163      153      -10     
Impacted Files Coverage Δ
src/MOI_wrapper/MOI_wrapper.jl 88.83% <100.00%> (+4.09%) ⬆️
src/debug.jl 100.00% <0.00%> (ø)
src/filter.jl 100.00% <0.00%> (ø)
src/bb_user_limits.jl 100.00% <0.00%> (ø)
src/bb_inits_and_defaults.jl 100.00% <0.00%> (ø)
src/table_log.jl 95.31% <0.00%> (+0.03%) ⬆️
src/fpump.jl 89.62% <0.00%> (+0.04%) ⬆️
src/bb_integral_or_branch.jl 97.22% <0.00%> (+0.07%) ⬆️
src/util.jl 73.78% <0.00%> (+0.16%) ⬆️
src/solver.jl 79.76% <0.00%> (+0.24%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec81a10...9dd85ae. Read the comment docs.

@odow odow changed the title WIP: Update to JuMP v0.23 and switch from Cbc to HiGHS Update to JuMP v0.23 and switch from Cbc to HiGHS Feb 28, 2022
@odow odow requested a review from ccoffrin February 28, 2022 01:22
@odow
Copy link
Collaborator Author

odow commented Feb 28, 2022

It's nice to see that HiGHS passes all the tests.

Comment on lines 18 to +19
MOIU.attach_optimizer(m)
bm = JuMP.backend(m)
options = bm.optimizer.model.optimizer.options
options = JuMP.unsafe_backend(m).options
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me this was the only breaking change that impacted Juniper in the move from MOI v0.10 to 1.0? Is that correct?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a change in how JuMP manages its backend.

I don't think we ever encouraged people to call .optimizer.model.optimizer, so this is arguably a bug-fix. We should have used direct_model if we cared about the backend. The new unsafe_backend provides a nice way to get the inner model for cases like this.

@odow odow merged commit 9b1c385 into master Feb 28, 2022
@odow odow deleted the od/jump-23 branch February 28, 2022 01:51
@odow odow mentioned this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants