Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support beta parameter in SoftPlus #114

Merged
merged 9 commits into from
Sep 26, 2024
Merged

Support beta parameter in SoftPlus #114

merged 9 commits into from
Sep 26, 2024

Conversation

Robbybp
Copy link
Collaborator

@Robbybp Robbybp commented Sep 24, 2024

Alternative to #112

src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
test/test_predictors.jl Outdated Show resolved Hide resolved
ext/MathOptAIPythonCallExt.jl Outdated Show resolved Hide resolved
src/predictors/SoftPlus.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. You should have permission to squash merge.

@Robbybp Robbybp merged commit 0901b31 into main Sep 26, 2024
@Robbybp Robbybp deleted the rp/torch-softplus-beta2 branch September 26, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants