Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use Julia v1.11 #133

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Update tests to use Julia v1.11 #133

merged 4 commits into from
Oct 18, 2024

Conversation

odow
Copy link
Collaborator

@odow odow commented Oct 18, 2024

Closes #127

@@ -26,7 +26,7 @@ end
function test_DecisionTree()
truth(x::Vector) = x[1] <= 0.5 ? -2 : (x[2] <= 0.3 ? 3 : 4)
rng = Random.MersenneTwister(1234)
features = rand(rng, 10, 2)
features = rand(rng, 100, 2)
Copy link
Collaborator Author

@odow odow Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By luck, the change from Julia 1.10 to 1.11 now means that features contained no points x <= [0.5, 0.3], so we never trained a tree to predict 3.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (d8e5b0e) to head (22c461b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   90.13%   89.78%   -0.36%     
==========================================
  Files          21       21              
  Lines         517      509       -8     
==========================================
- Hits          466      457       -9     
- Misses         51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow odow merged commit c2a1d5b into main Oct 18, 2024
6 of 7 checks passed
@odow odow deleted the od/test-1.11 branch October 18, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are flakey
1 participant