Add reduced_space option for PyTorchModel predictor
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This option needs to be added to the docstring, and we need a test 😄 But I can do it later if you don't have time. |
odow
reviewed
Aug 14, 2024
| # If config maps to a ReducedSpace predictor, we'll get a MethodError | ||
| # when trying to add the nested redcued space predictors. | ||
| # TODO: raise a nicer error or try to handle this gracefully. | ||
| inner_predictor = MathOptAI.ReducedSpace(inner_predictor) |
There was a problem hiding this comment.
Yeah, I wondered about adding ReducedSpace(predictor::ReducedSpace) = predictor, but I want to avoid magic where possible.
There was a problem hiding this comment.
That doesn't seem horrible to me, but probably best to at least wait until it comes up in a real workflow we want to support.
There was a problem hiding this comment.
Actually I don't think I had any tests for the PyTorch stuff because I didn't have CI set up yet.
|
I can update the docstring and add a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested locally...