[breaking] return a formulation object #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
odow
force-pushed
the
od/formulation
branch
2 times, most recently
from
4ad4992 to
191d681
Compare
odow
changed the title
|
So. This is ready for review. But I'm still not convinced what the best approach is. |
odow
commented
Aug 29, 2024
odow
commented
Aug 29, 2024
odow
commented
Aug 29, 2024
|
On réflection. I'm leaning towards merging this. It is a pretty disruptive PR to keep up to date with merge conflicts. |
|
I'm giving a talk about MathOptAI on the 24th, and I'd like this to be merged before then. The current implementation might not be everyone's ideal, but I think it's an okay start, and we can always change in future? |
odow
force-pushed
the
od/formulation
branch
from
4c14dab to
e1b46d1
Compare
|
I'm going to merge this, but leave #67 open, and we can continue to iterate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experiment with #67
I don't really like this yet. I need to look better at how other people do this.