Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing an existing file #193

Closed
wants to merge 1 commit into from
Closed

Conversation

nicolasbock
Copy link
Collaborator

@nicolasbock nicolasbock commented Mar 12, 2018

This change is Reviewable

@ghost ghost assigned nicolasbock Mar 12, 2018
@ghost ghost added the review label Mar 12, 2018
@nicolasbock
Copy link
Collaborator Author

Please don't merge. I am testing the danger plugin.

@nicolasbock
Copy link
Collaborator Author

Proselint found issues

README.md

Line Message Severity
50 Inconsistent spacing after period (1 vs. 2 spaces). warning
57 Inconsistent spacing after period (1 vs. 2 spaces). warning
182 Inconsistent spacing after period (1 vs. 2 spaces). warning
184 Inconsistent spacing after period (1 vs. 2 spaces). warning
202 No paragraph should start with a 'But'. warning

Generated by 🚫 Danger

@codecov-io
Copy link

Codecov Report

Merging #193 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #193    +/-   ##
======================================
+ Coverage      56%    56%   +<1%     
======================================
  Files         202    202            
  Lines        7550   7550            
  Branches      659    659            
======================================
+ Hits         4288   4289     +1     
  Misses       3122   3122            
+ Partials      140    139     -1
Impacted Files Coverage Δ
src/C-interface/ellsort/bml_add_ellsort_typed.c 39% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0f5d8...32883cf. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 59.609% when pulling 32883cf on nicolasbock:test_1 into 0a0f5d8 on lanl:master.

@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This PR is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the Stale label Feb 3, 2022
@nicolasbock nicolasbock closed this Feb 7, 2022
@nicolasbock nicolasbock deleted the test_1 branch February 7, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants