This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple of things:
If you'd like me to send this in without the cleanup feel free to say so. But I think it's good if this cleanup could be merged. Just let me know if you spot a couple of things which you dislike.
This is for a new major version so there are a few small breaking changes to method signatures. Here are some:
hasAddon
renamed tohasAddOn
to be conform with the rest of the AddOn naming$storagePath
param from thedownloadInvoice
method like on CashierAt the moment tests for PHP 7.3 are still failing because of a bug in the Braintree SDK. Waiting for a bugfix from their side before I bump the minimum PHP version: https://github.com/laravel/cashier-braintree/issues/61Bumped the minimum Braintree version for the crucial bugfix from the above issue ^