This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
Fix return type for getSubscriptionById on the WebhookController #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the return type here was too strict, since the `find` method could return null, e.g. if a subscription has been deleted, and that would cause an error. Also, on the `cancelSubscription` method we are checking if the $subscription is truthy, which means that is a valid case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the return type here was too strict, since the
findmethod could return null, e.g. if a subscription has been deleted, and that would cause an error.Also, on the
cancelSubscriptionmethod we are checking if the$subscriptionis truthy, which means that is a valid case.