-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.x] Preview upcoming invoice #1146
[13.x] Preview upcoming invoice #1146
Conversation
Cool stuff, thanks @benjamindoe! I think we can improve this further. Can we re-use the We can add an argument to Also: I believe we need to re-use |
For sure, I kind of just carved this out of my current app without much refactoring. I'll look into reusing I'll look at factoring out |
So unfortunately, |
Okay. Thanks for working on this @benjamindoe. I'll take it from here. |
47a0c1d
to
7225600
Compare
7225600
to
547dbe7
Compare
Thanks @benjamindoe. I've finished this PR. Managed to re-use |
Nice one... Interesting method |
Noticed this issue and thought I would suggest a PR since I've done something similar in my current project. Nothing fancy. Just a very basic method that has the same signature as the
swap
methodCloses #1142