[13.x] Fix webhook order issue #1243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
fix-webhook-order-issue
branch
from
2e07875 to
d0890d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at fixing the issue with the subscripion.updated webhook arriving sooner than the subscription.created webhook. What we'll do is create the subscription when it isn't yet created. This is a more safer way than delaying the handling by one second.
Should the susbcription.created webhook be handled later on, it won't be created twice since there's a check in the subscription.created handler.
I've also added two new unique indexes on stripe_id columns in the subscription tables. Honestly I don't know why these weren't there before.
I've tried this out and manages to confirm it fixes things for me in the situation that the subscription.updated webhook arrives first.
PS.: most of the changes in this PR are indentation changes.