Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Fix reference to billable #1363

Merged
merged 1 commit into from
May 12, 2022
Merged

[13.x] Fix reference to billable #1363

merged 1 commit into from
May 12, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented May 12, 2022

This should reference the billable rather than the Cashier class.

@driesvints driesvints changed the title Fix reference to billable [13.x] Fix reference to billable May 12, 2022
@taylorotwell taylorotwell merged commit 3e8f1e6 into 13.x May 12, 2022
@taylorotwell taylorotwell deleted the fix-billable-reference branch May 12, 2022 14:55
@sts-ryan-holton
Copy link

@driesvints This is an interesting change, noticing it's related to Cashier webhook? What were the potential issues with this prior to the change (if there were any)?

@driesvints
Copy link
Member Author

It's always better to reference a billable object since you may overwrite the stripe method on your model for some reason (although I don't recommend doing that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants