Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.x] Allow guest checkout #1438

Merged
merged 11 commits into from
Sep 20, 2022
Merged

[14.x] Allow guest checkout #1438

merged 11 commits into from
Sep 20, 2022

Conversation

alexanderkroneis
Copy link

This PR introduces a simple change of $owner in Checkout being nullable. This allows developers to implement a anonymous checkout / guest checkout for their applications.

Checkout::anonymous($sessionOptions);

@alexanderkroneis
Copy link
Author

I just recognized that there will be a null pointer exception and it seems this implementation is not possible.

@driesvints
Copy link
Member

It's possible. I think this is a good idea. Let me push some changes.

@driesvints
Copy link
Member

I renamed it to Checkout::guest($sessionOptions);.

@driesvints driesvints changed the title Allow anonymous checkout / guest checkout [14.x] Allow guest checkout Sep 20, 2022
@taylorotwell taylorotwell merged commit efda679 into laravel:14.x Sep 20, 2022
@driesvints
Copy link
Member

I'm gonna postpone releasing this. I'm working on a few improvements but ain't entirely happy yet with the implementation: #1439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants