-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.x] Allow guest checkout #1438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… check if owner is null
… check if owner is null
I just recognized that there will be a null pointer exception and it seems this implementation is not possible. |
It's possible. I think this is a good idea. Let me push some changes. |
I renamed it to |
driesvints
approved these changes
Sep 20, 2022
driesvints
changed the title
Allow anonymous checkout / guest checkout
[14.x] Allow guest checkout
Sep 20, 2022
I'm gonna postpone releasing this. I'm working on a few improvements but ain't entirely happy yet with the implementation: #1439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a simple change of
$owner
inCheckout
being nullable. This allows developers to implement a anonymous checkout / guest checkout for their applications.